Attention is currently required from: Jincheng Li, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Arthur Heymans has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/83331?usp=email )
Change subject: lib/smbios: Create SMBIOS type 4 entry
......................................................................
Patch Set 1:
(1 comment)
File src/lib/smbios.c:
https://review.coreboot.org/c/coreboot/+/83331/comment/f52e57de_983e27db?usp... :
PS1, Line 446: nsigned int __weak smbios_get_max_socket(void)
: {
: return 1;
: }
How about the following, without the weak function:
if (CONFIG_MAX_SOCKET == 1)
return 1;
else
return soc_get_num_socket();
Maybe you need to define that Kconfig MAX_SOCKET in some place else with default 1, but I think this approach is cleaner.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83331?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia47fb7c458f9e89ae63ca64c0d6678b55c9d9d37
Gerrit-Change-Number: 83331
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 03 Jul 2024 11:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No