Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33823 )
Change subject: include, lib: Add <inttypes.h> printf macros ......................................................................
Patch Set 14:
(7 comments)
https://review.coreboot.org/c/coreboot/+/33823/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33823/3//COMMIT_MSG@8 PS3, Line 8:
Why?
Done
https://review.coreboot.org/c/coreboot/+/33823/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33823/7//COMMIT_MSG@8 PS7, Line 8:
Please elaborate.
Done
https://review.coreboot.org/c/coreboot/+/33823/12/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/12/src/include/inttypes.h@22 PS12, Line 22: #ifdef __cplusplus
I guess we won't need this.
Done
https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/11/src/include/inttypes.h@71 PS11, Line 71: #define PRIiFAST8 "i" /* int_fast8_t */
I don't see a requirement. Simply, `h` for PRIi16 and `hh` for PRIi8 would […]
Done
https://review.coreboot.org/c/coreboot/+/33823/8/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/8/src/include/inttypes.h@60 PS8, Line 60: "lld"
this is not a CVS version
Done
https://review.coreboot.org/c/coreboot/+/33823/7/src/include/inttypes.h File src/include/inttypes.h:
https://review.coreboot.org/c/coreboot/+/33823/7/src/include/inttypes.h@154 PS7, Line 154: /* fscanf macros for signed integers */
There's no fscanf() in coreboot, so we don't really need any of the SCN (although they don't hurt ei […]
Done
https://review.coreboot.org/c/coreboot/+/33823/7/src/include/inttypes.h@246 PS7, Line 246: typedef struct {
I mean, just cutting out one contiguous block of lines is a pretty easy divergence to manage. […]
Done