Attention is currently required from: Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................
Patch Set 2:
(1 comment)
File util/cbfstool/cbfs_image.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135938):
https://review.coreboot.org/c/coreboot/+/60233/comment/928e1718_2bc6ff8e
PS2, Line 89: if (((char *)entry) + be32toh(entry->offset) == hdr_loc) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e
Gerrit-Change-Number: 60233
Gerrit-PatchSet: 2
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 01:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment