[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43741 )

Change subject: drivers/spi/tpm: Enable long cr50 ready pulses for Tiger Lake systems
......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43741/19/src/drivers/spi/tpm/tpm.c 
File src/drivers/spi/tpm/tpm.c:

https://review.coreboot.org/c/coreboot/+/43741/19/src/drivers/spi/tpm/tpm.c@... 
PS19, Line 510: 	if (get_cr50_board_cfg() & CR50_BOARD_CFG_100US_READY_PULSE)
> In a dependent CL, Furquan suggested that this method should call tlcl_lib_init(), in order to ensur […]

Honestly, long-term, I would prefer we just got rid of tlcl_lib_init() (and this whole tis_xxx() API that I think was just kinda copied from U-Boot but not enough of it to really make sense) and have a TPM stack that always automatically initializes on the first access. But for now where we still have it, I agree with Jes that it is usually called explicitly before calling low level TPM accessors so we should follow that convention.