Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46297 )
Change subject: device/pci: Add NULL check for PCI driver's .ops
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46297/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46297/1//COMMIT_MSG@10
PS1, Line 10: if `.ops` was set by a driver.
Maybe add:
This avoids a NULL pointer dereference in case a driver with NULL .ops would match.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dcc05ebb092fb9c4be929c81ea2b05a10b1311b
Gerrit-Change-Number: 46297
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment