Attention is currently required from: Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84407?usp=email )
Change subject: mb/google/fatcat: Add override tree
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/84407/comment/a07bb4c4_d5940f03?usp... :
PS1, Line 28: register "usb2_port_reset_msg_en[0]" = "1"
: register "usb2_port_reset_msg_en[1]" = "1"
: register "usb2_port_reset_msg_en[2]" = "1"
: register "usb2_port_reset_msg_en[3]" = "1"
Please let me know what this register is. We have not used this before.
That field was unnecessary so I removed it. Cf. https://review.coreboot.org/c/coreboot/+/84429/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84407?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d53
Gerrit-Change-Number: 84407
Gerrit-PatchSet: 9
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 20 Sep 2024 00:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pranava Y N
pranavayn@google.com