Attention is currently required from: Jérémy Compostella, Nico Huber.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83562?usp=email )
Change subject: arch/x86: Build all stages using the same function
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83562/comment/11a2644f_ad8a6d79?usp... :
PS1, Line 314: # The rmodule_link definition creates an elf file with .rmod extension.
Why drop this?
It confuses me. rmodule_link is not used here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83562?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I458c7c6822b310847e7ab32519fd8d66a90f88f7
Gerrit-Change-Number: 83562
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Comment-Date: Thu, 18 Jul 2024 21:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de