Attention is currently required from: Hung-Te Lin, Jarried Lin, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83925?usp=email )
Change subject: soc/mediatek/mt8196: Enable mmu operation for L2C SRAM and DMA ......................................................................
Patch Set 4: Code-Review+2
(3 comments)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83925/comment/f5dbb3c8_3a370af8?usp... : PS4, Line 14: romstage-y += ../common/cbmem.c : romstage-y += ../common/mmu_operations.c ../common/mmu_cmops.c l2c_ops.c : romstage-y += emi.c sort
https://review.coreboot.org/c/coreboot/+/83925/comment/2d266910_b877849c?usp... : PS4, Line 19: ramstage-y += soc.c : ramstage-y += ../common/mmu_operations.c ../common/mmu_cmops.c l2c_ops.c sort
File src/soc/mediatek/mt8196/l2c_ops.c:
https://review.coreboot.org/c/coreboot/+/83925/comment/96457dfb_9340faa3?usp... : PS4, Line 15: #define MP0_CLUSTER_CFG0 0x0C000060 : #define CLUST_DIS_VAL 0x3 : #define CLUST_DIS_SHIFT 0x4 fix the indentation