Dan Elkouby has posted comments on this change. ( https://review.coreboot.org/25663 )
Change subject: device/dram/ddr3: improve XMP support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@298 PS1, Line 298: /* Minimum CAS Write Latency Time (tCWLmin)
over line
Done
https://review.coreboot.org/#/c/25663/1/src/device/dram/ddr3.c@491 PS1, Line 491: /* CAS Latencies Supported */
According to spec 1.1 it's […]
Done
https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c File src/device/dram/ddr3.c:
https://review.coreboot.org/#/c/25663/2/src/device/dram/ddr3.c@584 PS2, Line 584: print_ns(" tCMDmin : ", dimm->tCMD);
It's not in units of ns, but tCK/ns
Should I add a function along the lines of print_tck for this?