Attention is currently required from: Hung-Te Lin, Jarried Lin, Xi Chen, Yidi Lin, Yu-Ping Wu.
Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83988?usp=email )
Change subject: soc/mediatek: Move GPIO definations to MediaTek common directory ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83988/comment/225bb73e_ada3b72a?usp... : PS1, Line 7: definations defin*i*tions
https://review.coreboot.org/c/coreboot/+/83988/comment/0c091d01_125dbc2f?usp... : PS1, Line 9: reduece reduce
https://review.coreboot.org/c/coreboot/+/83988/comment/9fe3e82d_7446c400?usp... : PS1, Line 9: definations definitions
https://review.coreboot.org/c/coreboot/+/83988/comment/76477e7c_39aacc7b?usp... : PS1, Line 10: definations Ditto.
File src/soc/mediatek/mt8173/include/soc/gpio_base.h:
https://review.coreboot.org/c/coreboot/+/83988/comment/a7699502_4ead6130?usp... : PS1, Line 7: typedef struct { : u32 id; : } gpio_t; Will this be compatible with the common files? (Sorry, no C expert.)