Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4144
-gerrit
commit 6117e431574ab464483cda1345c3d395b1e00cf9 Author: Gabe Black gabeblack@google.com Date: Thu Apr 25 17:21:58 2013 -0700
elog: Make sure the elog data structures are initialized in elog_clear.
If elog_clear is called before other elog functions, for instance if it's called through an SMI immediately after the system boots, then the elog data structures won't have been set up and the system will go off the deep end. This change adds a call to elog_init to elog_clear to make sure things things are always initialized before we start using them.
Before this change, this command would cause the system to lock up if run immediately after boot:
echo 1 > /sys/firmware/gsmi/clear_eventlog
After this change, that results in the log being cleared correctly.
Change-Id: I45027f0dbfa40ca8c581954a93b14b4fedce91ed Signed-off-by: Gabe Black gabeblack@google.com Reviewed-on: https://gerrit.chromium.org/gerrit/49303 Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Stefan Reinauer reinauer@google.com Commit-Queue: Gabe Black gabeblack@chromium.org Tested-by: Gabe Black gabeblack@chromium.org --- src/drivers/elog/elog.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 6e89b5f..6de5123 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -746,6 +746,10 @@ int elog_clear(void)
elog_debug("elog_clear()\n");
+ /* Make sure ELOG structures are initialized */ + if (elog_init() < 0) + return -1; + /* Erase flash area */ elog_flash_erase_area();