[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )

Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2: Code-Review-1
>
> (1 comment)
>
> extraneous/redundant uses of the Offset() are not needed :
> OperationRegion (OPR1, SystemMemory, 0x100, 0x100)
> Field (OPR1)
> {
>     Offset (0),     // Never needed
>     FLD1, 32,
>     Offset (4),     // Redundant, offset is already 4 (bytes)
>     FLD2, 8,
>     Offset (64),    // OK use of Offset.
>     FLD3, 16,
>
> }
>
> will give :
>
> dsdt.asl     14:         Offset (0),
> Remark   2158 -                 ^ Unnecessary/redundant use of Offset
> operator
>
> dsdt.asl     16:         Offset (4),
> Remark   2158 -                 ^ Unnecessary/redundant use of Offset
> operator

I don't see such warnings anywhere: https://paste.flashrom.org/view.php?id=3337

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... 
File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:

https://review.coreboot.org/c/coreboot/+/43160/2/src/southbridge/intel/i8280... 
PS2, Line 18: Offset (0x00),
> please remove this

Elyes, these are added for alignment purposes (i82801ix/i82801jx have them). This change makes globalnvs.asl for i82801{gx,ix,jx} *identical*

I can understand that Offset (0x00) is redundant, but I'd rather remove all instances of it on a separate commit. Does it sound good?