Attention is currently required from: Hung-Te Lin, Jianjun Wang, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/84113?usp=email )
Change subject: soc/mediatek/common/pcie: Add DEVTREE_CONST qualifier
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84113/comment/ac3a5fe7_0fe68222?usp... :
PS2, Line 12: src/soc/mediatek/common/pcie.c:104:26: error: assignment discards
When will this error show up? I mean, why didn't Jenkins build fail without this patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84113?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia7c95424019ec0dca50bbc6be7f81b6180d06d6e
Gerrit-Change-Number: 84113
Gerrit-PatchSet: 2
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Thu, 29 Aug 2024 08:53:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No