Attention is currently required from: Reka Norman, Paul Menzel, Rizwan Qureshi, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59752 )
Change subject: soc/intel/alderlake: Configure 9 I/O for ADL-N
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
PS2:
I'd squash CB:59751 into this change. It doesn't make sense to have the `SOC_INTEL_ALDERLAKE_PCH_N` option without the correct settings. I'd rewrite the commit message as follows:
soc/intel/alderlake: Add support for ADL-N
Introduce the `SOC_INTEL_ALDERLAKE_PCH_N` Kconfig option and
use it to specify the correct amount of PCIe I/O. Document number
645548 indicates that Alder Lake-N has 9 PCH root ports, no CPU
root ports, 5 clock sources and 5 clock request signals.
I don't know if the numbers are correct. If they aren't, just adapt this accordingly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59752
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ebbcdcdb1ccc34b80ec71ac3e591fe4ad6b1904
Gerrit-Change-Number: 59752
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kangheui Won
khwon@google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 12:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment