[coreboot-gerrit] [S] Change in coreboot[main]: mb/google/fatcat: Limit Power Limit when battery is missing

[Jérémy Compostella (Code Review)]

Attention is currently required from: Jamie Ryu, Paul Menzel, Subrata Banik.

Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85146?usp=email )

Change subject: mb/google/fatcat: Limit Power Limit when battery is missing
......................................................................

Patch Set 15:

(2 comments)

File src/mainboard/google/fatcat/variants/baseboard/fatcat/ramstage.c:

https://review.coreboot.org/c/coreboot/+/85146/comment/b8a3d96b_402251d1?usp... :
PS14, Line 25: /* If battery is not present, limit the power to the power optimized configuration. */
> Could be omitted as the code below is (luckily) very readable/understandable.

Done

https://review.coreboot.org/c/coreboot/+/85146/comment/4aa2b2a8_860451b1?usp... :
PS14, Line 26: 	if (!google_chromeec_is_battery_present())
> do we need `if (CONFIG(EC_GOOGLE_CHROMEEC)) {` check as well ? […]

`EC_GOOGLE_CHROMEEC` is part of `BOARD_GOOGLE_FATCAT_COMMON` which is selected by `BOARD_GOOGLE_BASEBOARD_FATCAT` so I assumed that this test should be unnecessary.