Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35595 )
Change subject: soc/intel/cannonlake: Fix FSP UPDs settings with disabled GBE
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35595/3/3rdparty/intel-microcode
File 3rdparty/intel-microcode:
https://review.coreboot.org/c/coreboot/+/35595/3/3rdparty/intel-microcode@1
PS3, Line 1: mmit ee319ae7bc59e88b60142f40a9ec1b46656de4db
sorry, i will fix it.
Done
https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs...
PS2, Line 196: SlpS0WithGbeSupport
Hi Fuquan, […]
Ack
https://review.coreboot.org/c/coreboot/+/35595/2/src/soc/intel/cannonlake/fs...
PS2, Line 207: && params->PchLanEnable
ok, i will add comment here. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35595
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I154a4e6970f99360aeb880d576eb61528034f7b6
Gerrit-Change-Number: 35595
Gerrit-PatchSet: 4
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Oct 2019 20:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment