Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: {mb,soc/intel/skylake}: Update GFX devtree options
......................................................................
Patch Set 7: Code-Review-1
IMO, this patch does too much at once to keep track of
everything...
Open questions:
* Why change the PrimaryDisplay setting of h110m?
* Why would we ever set `PrimaryDisplay = Display_Auto` together with `SkipExtGfxScan`?
* If I didn't miss it, the `SkipExtGfxScan` UPD wasn't set before? So this change changes all boards without mentioning it?
* What does `SkipExtGfxScan` do anyway?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 7
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Tue, 02 Apr 2019 08:19:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment