1 Mar
2021
1 Mar
'21
11:32 p.m.
Attention is currently required from: Mary Ruthven, Joel Kitching, Furquan Shaikh, Vadim Bendebury, Christian Walter, Julius Werner. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51164 )
Change subject: security/tpm/tss/vendor/cr50: Introduce vendor sub-command to reset EC ......................................................................
Patch Set 2:
(1 comment)
File src/security/tpm/tss/vendor/cr50/cr50.c:
https://review.coreboot.org/c/coreboot/+/51164/comment/366a021d_4414704b PS1, Line 155: mode_command
nit: Shouldn't this be named reset_command or just cmd? I think mode_command was used in `tlcl_cr50_ […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/51164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46063678511d27fea5eabbd12fc3af0b1df68143
Gerrit-Change-Number: 51164
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Mary Ruthven mruthven@google.com
Gerrit-Reviewer: Vadim Bendebury vbendeb@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Mary Ruthven mruthven@google.com
Gerrit-Attention: Joel Kitching kitching@google.com
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Vadim Bendebury vbendeb@google.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 02 Mar 2021 07:32:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment