Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45915 )
Change subject: nb/intel/gm45/memmap.c: Use `postcar_enable_tseg_cache` ......................................................................
nb/intel/gm45/memmap.c: Use `postcar_enable_tseg_cache`
Also correct comments and clean up cosmetics of this function.
Change-Id: I5f559d63bec15351b42b29ad97574ceb2c995039 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/gm45/memmap.c 1 file changed, 4 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/45915/1
diff --git a/src/northbridge/intel/gm45/memmap.c b/src/northbridge/intel/gm45/memmap.c index 4fe3998..da5e0ed 100644 --- a/src/northbridge/intel/gm45/memmap.c +++ b/src/northbridge/intel/gm45/memmap.c @@ -119,13 +119,10 @@ { uintptr_t top_of_ram;
- /* Cache 8 MiB region below the top of RAM and 2 MiB above top of - * RAM to cover both cbmem as the TSEG region. - */ + /* Cache 8 MiB region below the top of RAM to cover CBMEM */ top_of_ram = (uintptr_t)cbmem_top(); - postcar_frame_add_mtrr(pcf, top_of_ram - 8*MiB, 8*MiB, - MTRR_TYPE_WRBACK); - postcar_frame_add_mtrr(pcf, northbridge_get_tseg_base(), - northbridge_get_tseg_size(), MTRR_TYPE_WRBACK); + postcar_frame_add_mtrr(pcf, top_of_ram - 8 * MiB, 8 * MiB, MTRR_TYPE_WRBACK);
+ /* Cache the TSEG region */ + postcar_enable_tseg_cache(pcf); }