Attention is currently required from: Angel Pons, Christian Walter, Jincheng Li, Jérémy Compostella, Shuo Liu, Subrata Banik, Uwe Poeche, yuchi.chen@intel.com.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85568?usp=email )
Change subject: cpu/intel/car/romstage: Fix false-positive stack corruption
......................................................................
Patch Set 4:
(3 comments)
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/85568/comment/966159c4_7157b3ba?usp... :
PS3, Line 45: behviour
typo: […]
Done
https://review.coreboot.org/c/coreboot/+/85568/comment/19325e65_3f023bd8?usp... :
PS3, Line 47: serve
typo? […]
Done
https://review.coreboot.org/c/coreboot/+/85568/comment/542a86f1_9b7cd03b?usp... :
PS3, Line 50: * When HW breakpoints are used and enabled the stack canary breakpoint will
: * report the instruction pointer immediately and thus gives hint which function
: * does use too much stack. FSP might disable HW breakpoints though.
nit: some grammar fixes and a bit of rewording […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85568?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7ebf0a5e8eaad49af77ab4d5f6b58fc849013b14
Gerrit-Change-Number: 85568
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: siemens-bot
Gerrit-Reviewer: yuchi.chen@intel.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Uwe Poeche
uwe.poeche@siemens.com
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Tue, 17 Dec 2024 08:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com