Attention is currently required from: Bora Guvendik, Anil Kumar K, Selma Bensaid, Paul Menzel, Sridhar Siricilla, Bernardo Perez Priego. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58101 )
Change subject: lib/spd_bin: Fix for LDDR5 ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58101/comment/aff75976_68290273 PS5, Line 9: Added LDDR5 for the param : Fixed SPD name for LDDR5
Please format it as a list, and use imperative mood (Add, Fix).
Done
https://review.coreboot.org/c/coreboot/+/58101/comment/91231e90_5006ebec PS5, Line 11: with
With
Done
https://review.coreboot.org/c/coreboot/+/58101/comment/df57cc57_ddce9f60 PS5, Line 11: with this change, we won't get this warning message:
Please add a blank line above, and maybe just write: […]
Done
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/58101/comment/38eb4d53_df4291a7 PS5, Line 27: use_ddr4_params
This name should be updated, if DDR5 is also handled.
Done
https://review.coreboot.org/c/coreboot/+/58101/comment/2753aedd_ca4a1cf7 PS5, Line 37: case SPD_DRAM_LPDDR5:
Please order it one line below.
Done
https://review.coreboot.org/c/coreboot/+/58101/comment/8bb3d786_4591ac4a PS5, Line 169: case SPD_DRAM_LPDDR5:
Please order it below.
Done