Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31474 )
Change subject: vboot: standardize on working data size ......................................................................
Patch Set 13:
Patch Set 13: But I'm not so sure about these other errors:
make[2]: Entering directory '/home/coreboot/slave-root/workspace/coreboot-gerrit/src/soc/nvidia/tegra124/lp0' arm-eabi-gcc -marm -march=armv4t -mno-unaligned-access -nostdlib -static \ -Os -fpie -Wl,--build-id=none -ggdb3 -T tegra_lp0_resume.ld \ -I ../../../../include -I ../../../../arch/arm/include \ -include ../../../../commonlib/include/commonlib/compiler.h \ -o tegra_lp0_resume.elf tegra_lp0_resume.c tegra_lp0_resume.c:267:40: error: static declaration of 'halt' follows non-static declaration static __always_inline void __noreturn halt(void) ^~~~ In file included from tegra_lp0_resume.c:17: ../../../../include/halt.h:26:17: note: previous declaration of 'halt' was here void __noreturn halt(void); ^~~~ make[2]: *** [Makefile:35: tegra_lp0_resume.elf] Error 1 make[2]: Leaving directory '/home/coreboot/slave-root/workspace/coreboot-gerrit/src/soc/nvidia/tegra124/lp0'
https://review.coreboot.org/c/coreboot/+/31979 slipped through