Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74592 )
Change subject: mb/google/skyrim: rename baseboard gpios in gpio.c ......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74592/comment/d4dc4586_ff6f62ae PS2, Line 9: Add named GPIO's to help prevent confusion in GPIO management
BUILD_TIMELESS=1 emerge-... coreboot […]
That link was broken for me: https://source.chromium.org/chromium/chromiumos/third_party/coreboot/+/chrom...
File src/mainboard/google/skyrim/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/73608d9c_0c8b916a PS2, Line 38: .gpio_group_id = SSD_AUX_RST_L,
SD_AUX_RST_SOC_L
Done
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/3b9e0c16_0c3659c5 PS2, Line 10: SYS_RST_ODL
We may not be configuring the GPIOs in other places, but we are referencing them. […]
Split everything except gpio.c into a separate CL
File src/mainboard/google/skyrim/variants/markarth/gpio.c:
https://review.coreboot.org/c/coreboot/+/74592/comment/93172267_4b03ad4f PS2, Line 10: PAD_NC(GPIO_3),
I know these are not named b/c they are not used, but it feels like another place in code we could f […]
We can just delete the name from the baseboard and leave it as unused