Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32000 )
Change subject: soc/intel/apollolake: Add support to log XHCI wake events
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/32000/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32000/1//COMMIT_MSG@16
PS1, Line 16: S0ix Enter
Works with S3 too?
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c
File src/soc/intel/apollolake/elog.c:
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c@28
PS1, Line 28: #define XHCI_USB2_PORT_STATUS_REG 0x480
: #define XHCI_USB3_PORT_STATUS_REG 0x510
: #define XHCI_USB2_PORT_NUM 9
: #define XHCI_USB3_PORT_NUM 7
Are these true for both APL and GLK?
https://review.coreboot.org/#/c/32000/1/src/soc/intel/apollolake/elog.c@33
PS1, Line 33: static struct xhci_usb_info usb_info = {
const
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55b850646dda8acaa086a9012c2d8b611016f932
Gerrit-Change-Number: 32000
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 Mar 2019 21:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment