Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak.
Hello Lance Zhao, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76000?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: acpi: Swap XSDT and RSDT in acpi_add_table() ......................................................................
acpi: Swap XSDT and RSDT in acpi_add_table()
If ACPI is above 4G it's not possible to have a valid RSDT pointer in RSDP, therefore swap RSDT and XSDT. Both are always generated on x86. On other architecures RSDT is often skipped, e.g. aarch64. On top of that the OS looks at XSDT first. So unconditionally using XSDT and not RSDT is fine.
This also deal with the ACPI pointer being above 4G. This currently never happens with x86 platforms.
Signed-off-by: Arthur Heymans arthur@aheymans.xyz Change-Id: I6588676186faa896b6076f871d7f8f633db21e70 --- M src/acpi/acpi.c 1 file changed, 25 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/76000/2