Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35226 )
Change subject: src/soc/intel/common/block/cse: Make hfsts1 common & add helper functions ......................................................................
Patch Set 17:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... PS17, Line 247: int unsigned int?
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... PS17, Line 253: else : return 0; you can skip the else and directly return 0, if above condition is true the function would anyways return 1.
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... PS17, Line 268: int unsigned int?
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/common/block... PS17, Line 32: hfsts1 nit:me_hsts1? to be consistent with SOC definitions for rest of the hstsx used in SOC code.
Also add a comment for the register information. like the SOC code used to have: /* ME Host Firmware Status Register 1 */
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/skylake/me.c File src/soc/intel/skylake/me.c:
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/skylake/me.c... PS17, Line 285: hfs hsf1?
https://review.coreboot.org/c/coreboot/+/35226/17/src/soc/intel/skylake/me.c... PS17, Line 487: hfs same.