Attention is currently required from: Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59355 )
Change subject: soc/intel/alderlake: remove tmp bar assignment for cpu crashlog
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/59355/comment/99a27ef6_4f318db6
PS8, Line 213: printk(BIOS_DEBUG, "cpu crashlog bar addr: 0x%X\n",
: pci_read_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_0));
No need to read PCI config space then. Use the resources attached to the device. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e6772be51ec4f26ef31fed6cb2bddef8ffc6be
Gerrit-Change-Number: 59355
Gerrit-PatchSet: 9
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 22 Nov 2021 03:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment