Attention is currently required from: Bao Zheng, Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 )
Change subject: amdfwtool: Add support for AMD's BIOS A/B recovery feature
......................................................................
Patch Set 36:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/56773/comment/a1ddcd86_bb8b02f2
PS36, Line 264: { .type = AMD_ABL0, .level = PSP_BOTH | PSP_LVL2_AB },
: { .type = AMD_ABL1, .level = PSP_BOTH },
: { .type = AMD_ABL2, .level = PSP_BOTH },
: { .type = AMD_ABL3, .level = PSP_BOTH },
: { .type = AMD_ABL4, .level = PSP_BOTH },
: { .type = AMD_ABL5, .level = PSP_BOTH },
: { .type = AMD_ABL6, .level = PSP_BOTH },
: { .type = AMD_ABL7, .level = PSP_BOTH },
from the documentation i'd assume that those should all be the same. not sure that it would make a difference in practice, since the newer socs seem to only use abl0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56773
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036
Gerrit-Change-Number: 56773
Gerrit-PatchSet: 36
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Wed, 17 Nov 2021 00:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment