Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43764 )
Change subject: mb/google/volteer: Add gpio-keys ACPI node for PENH
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43764/6/src/mainboard/google/voltee...
File src/mainboard/google/volteer/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/43764/6/src/mainboard/google/voltee...
PS6, Line 29: DRIVERS_GENERIC_GPIO_KEYS
nit: It is also fine to just put this selection in Kconfig under BOARD_GOOGLE_BASEBOARD_VOLTEER as the gpio_keys driver will be optimized out by the linker if it is unused.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida3217a5b156320856ce3302c2623eba2230f28d
Gerrit-Change-Number: 43764
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Levin
levinale@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Jul 2020 22:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment