Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43809 )
Change subject: mb/asus/p2b,emulation/qemu: Drop select SMP ......................................................................
mb/asus/p2b,emulation/qemu: Drop select SMP
With MAX_CPUS > 1, SMP remains selected.
With MAX_CPUS==1, this has the effect of removing spinlock implementation. But since is_smp_boot() evaluates false and SMM uses separate smi_semaphore, there is no concurrency to protect against with a spinlock.
Change-Id: I9048a4821f19d90e1489b09e294d2551941abf10 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/qemu-x86/Kconfig M src/mainboard/asus/p2b/Kconfig 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/43809/1
diff --git a/src/cpu/qemu-x86/Kconfig b/src/cpu/qemu-x86/Kconfig index 21ada02..3136162 100644 --- a/src/cpu/qemu-x86/Kconfig +++ b/src/cpu/qemu-x86/Kconfig @@ -6,7 +6,6 @@ select ARCH_VERSTAGE_X86_32 select ARCH_ROMSTAGE_X86_32 select ARCH_RAMSTAGE_X86_32 - select SMP select UDELAY_TSC select TSC_MONOTONIC_TIMER select UNKNOWN_TSC_RATE diff --git a/src/mainboard/asus/p2b/Kconfig b/src/mainboard/asus/p2b/Kconfig index 00295be..1d3d3b9 100644 --- a/src/mainboard/asus/p2b/Kconfig +++ b/src/mainboard/asus/p2b/Kconfig @@ -7,7 +7,6 @@ select SDRAMPWR_4DIMM select HAVE_MP_TABLE select IOAPIC - select SMP
config BOARD_SPECIFIC_OPTIONS def_bool y