Attention is currently required from: Martin Roth, Piotr Król. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59169 )
Change subject: utils: Add initial version of "remove_unused_code" script ......................................................................
Patch Set 2:
(10 comments)
File util/scripts/rm_unused_code:
https://review.coreboot.org/c/coreboot/+/59169/comment/ba1cfa39_c4b8b98d PS1, Line 115: ${dir}
Done
Looks like it's still missing
https://review.coreboot.org/c/coreboot/+/59169/comment/7f8ac73d_854131bb PS1, Line 125: ${dir}
Done
Still missing
https://review.coreboot.org/c/coreboot/+/59169/comment/b195f3a5_39919820 PS1, Line 214: ${CONFIG_FILE}
Done
Quotes missing
https://review.coreboot.org/c/coreboot/+/59169/comment/23380721_e5d2ba20 PS1, Line 221: || exit 1
Right. This is left over from before I had the -e. Removed.
Still here
File util/scripts/rm_unused_code:
https://review.coreboot.org/c/coreboot/+/59169/comment/cfb70387_07557a0d PS2, Line 20: ${CLEAN_DIR_LIST} What's this for?
https://review.coreboot.org/c/coreboot/+/59169/comment/d361a03e_995f11c0 PS2, Line 120: exit Do you really want to exit the whole script?
https://review.coreboot.org/c/coreboot/+/59169/comment/8c70a84a_215d10bb PS2, Line 120: then Why the single line?
https://review.coreboot.org/c/coreboot/+/59169/comment/093afb48_5b60b774 PS2, Line 120: && I think you can remove this
https://review.coreboot.org/c/coreboot/+/59169/comment/29bfac40_50320d42 PS2, Line 121: cd "${file} Is this expected to have a side effect?
https://review.coreboot.org/c/coreboot/+/59169/comment/469e7577_f7399193 PS2, Line 121: find . -maxdepth 1 Can this line be simplified `if [[ -e "${file}/Makefile" ]]`?