Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42650 )
Change subject: sb/intel/i82801gx: Move `acpi_fill_fadt` to fadt.c
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/fadt.c:
https://review.coreboot.org/c/coreboot/+/42650/1/src/southbridge/intel/i8280...
PS1, Line 35: 1
ACPI_ADDRESS_SPACE_IO
I am just cutting and pasting the code. I will not change anything in this commit to ease review. I can take care of these later, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42650
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ff2459d82eb7933ed80180a69f0f323b8ecd25f
Gerrit-Change-Number: 42650
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 21 Jun 2020 16:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment