Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36014 )
Change subject: soc/mediatek/mt8183: Verify checksum of cached calibration data
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36014/2/src/soc/mediatek/mt8183/mem...
File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36014/2/src/soc/mediatek/mt8183/mem...
PS2, Line 99: BIOS_ERR
also print expected and saved values.
https://review.coreboot.org/c/coreboot/+/36014/2/src/soc/mediatek/mt8183/mem...
PS2, Line 184: %#x\
move this to 'improve code formatting' patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36014
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a0688ed6e560d4c0c6b316f44e52fd10d71a9d
Gerrit-Change-Number: 36014
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Oct 2019 02:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment