Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/85520?usp=email )
Change subject: mb/google/nissa/var/riven: Set PCIe root port 4 speed to Gen2
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85520/comment/b445c5bb_c638a19b?usp... :
PS3, Line 10:
The issue does not occur on Karis due to different WIFI module type with current projects, Karis is using M.2 (none solder down version),The decision to set PCIe root port 4 speed to Gen2 is based on experiment setup for b/374205496 and analysis result in #102, We appreciate your understanding and kindly request your assistance in reviewing this. Thank you!
do you mind adding such details into commit msg for better code readability.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85520?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ife2b60e78f943545fabd7095bd00d22704587aba
Gerrit-Change-Number: 85520
Gerrit-PatchSet: 4
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Sat, 07 Dec 2024 03:52:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com