Attention is currently required from: David Wu, Tim Wawrzynczak, Ren Kuo, Sumeet R Pawnikar, Nick Vaccaro, Alan Huang.
Peter Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62466 )
Change subject: mb/google/brya/var/kano: Update TDP PL1, PL2, and PL4 for U28 SKUs
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/brya/variants/kano/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62466/comment/c5d78ec7_8e3f3ff0
PS3, Line 134: 20000
Lowering PL1 max power value will impact the overall system performance.
our thermal design target is 18~20w, we still concern the thermal event when PL1 is over the TDP so we adjust the power limit.
https://review.coreboot.org/c/coreboot/+/62466/comment/f69c8c73_556bf104
PS3, Line 141: 43000
Normally, we keep max and min power value the same for PL2. […]
please David help to change the PL2_Mix/Min to 43W.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82e2dbacd6cbc39390eb28f27ca9db48d6c215c
Gerrit-Change-Number: 62466
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Peter Ou
peter.ou@quanta.corp-partner.google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Mar 2022 02:38:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment