Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41442 )
Change subject: device: Move resource allocation into a separate compilation unit
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@9
PS2, Line 9: alllocator
allocator
note: problem is that there are three `l` instead of two
https://review.coreboot.org/c/coreboot/+/41442/2//COMMIT_MSG@23
PS2, Line 23: RESOURCE_ALLOCATOR_V3
Out of curiosity, why is it called V3?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41442
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f5440cf83c6e9e15a5f22e79cc3c66aa2cec4c0
Gerrit-Change-Number: 41442
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Sat, 16 May 2020 10:22:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment