Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33382 )
Change subject: [WIP] mb/google/{sarien, arcada} Fix for SSD can't be detected issue
......................................................................
Patch Set 5:
(1 comment)
The change seems largely fine now. At what point will your team have confidence and want to remove the WIP and commit it?
https://review.coreboot.org/#/c/33382/5/src/mainboard/google/sarien/romstage...
File src/mainboard/google/sarien/romstage.c:
https://review.coreboot.org/#/c/33382/5/src/mainboard/google/sarien/romstage...
PS5, Line 67: if (acpi_get_sleep_type() == ACPI_S5) {
just a comment here to explain why this is necessary
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03dabe1f75c761617c1129547342dff3047e101d
Gerrit-Change-Number: 33382
Gerrit-PatchSet: 5
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Jun 2019 19:26:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment