Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33796 )
Change subject: asus/am1i-a: Fix UART 0 port while preserving UART 1 functionality
......................................................................
Patch Set 4: Code-Review+2
In the case of legacy PNP UARTs in superio, almost nobody cares about checking UART_FOR_CONSOLE at build time. You could use '#error' for >1.
Also: CB:31934 (if rebased and completely applied) will revisit this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6579aa8fd092da84f8afdcc33496db45c582919f
Gerrit-Change-Number: 33796
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 26 Jun 2019 22:45:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment