[coreboot-gerrit] [M] Change in coreboot[main]: tree: Use boolean for dptf_enable

[Nico Huber (Code Review)]

Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Eran Mitrani, Eric Lai, Frans Hendriks, Jakub Czapiga, Jayvik Desai, Jonathon Hall, Kapil Porwal, Lean Sheng Tan, Maxim, Michał Żygowski, Nick Vaccaro, Piotr Król, Pranava Y N, Rishika Raj, Subrata Banik, Tarun, Werner Zeh.

Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84161?usp=email )

Change subject: tree: Use boolean for dptf_enable
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> For my understanding, the natural language for "dptf_enable" would be "yes/no".

Works too, sure. I would call it `dptf_enabled` or `enable_dptf` then, though.
Anyway, I think we should make a decision for the patch series as a whole.
(Personally, I prefer to leave this to the individual, original author.)
> C23 will not warn as probably it will convert int(0, 1) to bool(false, true) and this patch not about removing any warning. It is about using something that modern C provides.

C provides that, yes. Doesn't mean we have to use it when it makes things harder to read.
> (out of topic: the switch [1], is on or off?  :p )

To me that's on (circuit closed). I find these much easier to read than sliders ;)