Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30985 )
Change subject: postcarpayload: Boot to payload from postcar stage directly [WIP]
......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/#/c/30985/20/src/arch/x86/c_postcar_start.S
File src/arch/x86/c_postcar_start.S:
https://review.coreboot.org/#/c/30985/20/src/arch/x86/c_postcar_start.S@12
PS20, Line 12: */
Why is this needed? And why are we effectively duplicating things from ramstage?
this is only needed to perform GDT and IDT programming as on S3 resume, it will depend on coreboot to restore the same.
i'm working to avoid the duplication of things. but looks like we need to have GDT/IDT programming in earlier stage if wish to skip ramstage
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27479187461ceb078167f2d726f40839865a9233
Gerrit-Change-Number: 30985
Gerrit-PatchSet: 20
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-Comment-Date: Fri, 24 May 2019 19:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment