Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36589 )
Change subject: cpu/x86/smm: Add helper functions to deal with different save states
......................................................................
Patch Set 3:
We have something similar in src/soc/intel/common/block/include/intelblocks/smihandler.h and src/soc/intel/common/block/smm/smihandler.c where the ops are about getting and setting a register.
1. Why is this about pointers to registers and not just getting and setting the explicit register?
2. I prefer the ops-based approach because the chipset can say "these are my ops" and the other save state versions are garbage collected instead of carrying support for save state versions in the binary.
3. Are we planning on converging/sharing the implementation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36589
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85325a25dc38d7cfc7eb0dfde621e5ebfeef0e15
Gerrit-Change-Number: 36589
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Nov 2019 16:22:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment