Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jayvik Desai, Kapil Porwal, Paul Menzel, Subrata Banik.
Julius Werner has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85326?usp=email )
Change subject: ec/google/chromeec: Add debug timestamp for host EC commands ......................................................................
Patch Set 11:
(1 comment)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/85326/comment/9e2a9059_95b2b655?usp... : PS9, Line 286: printk
Please call stopwatch_tick() before accessing sw.current. […]
So would you want to use the same timestamp index for each command? Because I think that would look very confusing, trying to figure out which timestamp came from what command. Isn't a log that can display the command code right next to the time much better for this?
I'm also not sure it's a good idea in general to add Kconfig-conditional timestamps that only turn up in certain debug builds. Since the timestamp system always measures the time between two timestamps, this would shift other times around in unexpected ways when you turn on the option. I think the timestamp system is best for a consistent, high-level overview of which general parts of the boot flow take how much time, and then when drilling down into detail adding extra log messages that can be conditionally enabled is the better tool.