build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44941 )
Change subject: sumeet: add dptf support for SKUs ......................................................................
Patch Set 1:
(14 comments)
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... File src/soc/intel/common/block/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 32: void set_dptf_config (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 49: for (i = 0; i < ARRAY_SIZE(sku_table); i++) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 50: //if (cpu_table[i].cpuid == cpu_id) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 51: if (sku_table[i].skuid == sku_id) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 51: if (sku_table[i].skuid == sku_id) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 51: if (sku_table[i].skuid == sku_id) { suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 52: //cpu_type = cpu_table[i].name; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 53: sku_type = sku_table[i].name; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 53: sku_type = sku_table[i].name; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 54: break; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 54: break; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 55: } code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 55: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/44941/1/src/soc/intel/common/block/... PS1, Line 56: } please, no spaces at the start of a line