Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31358 )
Change subject: mb/google/hatch: Use MEM_CH_SEL to indicate single_channel sku
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31358/3/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/memory.c:
https://review.coreboot.org/#/c/31358/3/src/mainboard/google/hatch/variants/...
PS3, Line 22:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
But why not just have: […]
Making the struct non-const results in the error that I mentioned before:
Forbidden global variables in romstage:
CC firmware/2lib/2crc8.o
ffffff30 d _GLOBAL_OFFSET_TABLE_
ffffff00 d baseboard_memcfg
CC firmware/lib20/packed_key.o
make: *** [src/arch/x86/Makefile.inc:249: build-hatch/cbfs/fallback/romstage.debug] Error 1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89d022793580be603a93d0b177d73ce968529b5c
Gerrit-Change-Number: 31358
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 12 Feb 2019 17:56:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment