Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Name of user not set #1005382, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 7:
(1 comment)
File util/genbuild_h/genbuild_h.sh:
https://review.coreboot.org/c/coreboot/+/82006/comment/0cf45692_25a3e49b :
PS7, Line 37: H
does %H vs %h make any difference? would probably be good to use the same as in the already existing […]
%H (capital H) gives the complete hash. Now, is the complete hash really necessary? I thought of hash collisions in the future. But that might be too far fetched. I can stick to %h (small H) for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Name of user not set #1005382
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Name of user not set #1005382
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 22 Apr 2024 22:55:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment