Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Varun Upadhyay.
Hello Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Varun Upadhyay,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83898?usp=email
to look at the new patch set (#2).
Change subject: soc/intel/alderlake: Correct ISH partition availability check ......................................................................
soc/intel/alderlake: Correct ISH partition availability check
The previous implementation incorrectly assumed that the presence of a UFS device implied the availability of the ISH partition. This is not always true, especially on Alder Lake platforms where ISH may be enabled by default even without UFS.
This patch fixes the issue by directly checking for the presence of the ISH device to determine if the ISH partition is available.
BUG=b:359440547 TEST=1. Able to dump the ISH version with UFS device:
``` tirwen-rev3 ~ # cbmem -c -1 | grep ISH [DEBUG] ISH version: 5.4.2.7780 ```
2. Able to dump the ISH version with eMMC device:
``` trulo-rev1 ~ # cbmem -c | grep ISH [DEBUG] ISH version: 5.4.2.7780 ```
Change-Id: I411e36606c0697f91050af40e0636f7c64810e95 Signed-off-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/alderlake/chip.c 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/83898/2