Attention is currently required from: Francois Toguo Fotso, Furquan Shaikh, Subrata Banik, Nick Vaccaro, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57685 )
Change subject: soc/intel/common: Add CPU Crashlog PCI driver
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/common/block/crashlog/cpu_crashlog.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140418):
https://review.coreboot.org/c/coreboot/+/57685/comment/78740f73_09a9aaae
PS8, Line 236: printk(BIOS_INFO, "Collected %lu bytes of CPU crashlog data " \
Avoid unnecessary line continuations
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5cb61fa2570adcfe51680141ee12e0e83930bb19
Gerrit-Change-Number: 57685
Gerrit-PatchSet: 8
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 09 Feb 2022 13:11:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment