Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/43563 )
Change subject: Move `PSR_Off` out of `Power_And_Clocks_Haswell`
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/43563/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/43563/1//COMMIT_MSG@22
PS1, Line 22: the
: order in which they are written to changes
Does it? did you check a log? […]
Before:
type Pipe is (EDP, A, B, C);
Now:
type Transcoder_Index is (Trans_EDP, Trans_A, Trans_B, Trans_C);
I guess this was because I was starving when I wrote that. I'll fix.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/43563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I7483409b8b7db58874cbba3c0a7edb1968bba456
Gerrit-Change-Number: 43563
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 19 Jul 2020 12:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment