Attention is currently required from: Arthur Heymans, Kapil Porwal, Lean Sheng Tan, Subrata Banik, Werner Zeh.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76393?usp=email )
Change subject: src: Implement framework for PRERAM VSD store ......................................................................
Patch Set 13:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76393/comment/f82be437_59405a16 : PS10, Line 7: src/
Please remove.
Acknowledged
https://review.coreboot.org/c/coreboot/+/76393/comment/6286cecc_b4d922da : PS10, Line 8:
Please describe the problem, you are trying to solve.
Updated description.
Commit Message:
https://review.coreboot.org/c/coreboot/+/76393/comment/809e3fdb_27ad0921 : PS12, Line 9: This patch implements a framework that stores Vendor Specific Data
`'intialized' may be misspelled - perhaps 'initialized'?` […]
Acknowledged
File src/commonlib/bsd/include/commonlib/bsd/cbmem_id.h:
https://review.coreboot.org/c/coreboot/+/76393/comment/3728e8fd_0943f3de : PS12, Line 91: 0x43565344
signature should be `_VSD` in little-endian format
Acknowledged
File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/76393/comment/23d308be_604c12e4 : PS12, Line 9: #include <cbmem_vsd.h>
Remove it.
Acknowledged
File src/lib/cbmem_vsd.c:
https://review.coreboot.org/c/coreboot/+/76393/comment/928d9ce4_0c9258f6 : PS12, Line 40: : user_area = cbmem_add(CBMEM_ID_VSD, req_size); :
brace around
Acknowledged
https://review.coreboot.org/c/coreboot/+/76393/comment/47e3fb56_09ee4d03 : PS12, Line 55: if(!cbmem_area)
`space required before the open parenthesis '('` […]
Acknowledged