Attention is currently required from: Felix Singer.
Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/85641?usp=email )
Change subject: mb/erying/tgl: Cleanup the code
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85641/comment/2582df60_bbdf2d7c?usp... :
PS3, Line 11: - Moving SuperIO configuration to bootblock to make devtree cleaner
That is meant to be in the devicetree.
I meant SIO GPIO. Angel did it the same way for Odroid H4+, looks much neater in my opinion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e395220025fc13e0589472e4732ea1495668554
Gerrit-Change-Number: 85641
Gerrit-PatchSet: 3
Gerrit-Owner: Alicja Michalska
ahplka19@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Comment-Date: Thu, 19 Dec 2024 22:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de